Good idea! In the situation I based this on PersonCode was always taken as a priority. There could be all sorts of crap in Notes and we wanted to avoid any false positives. Never really trusted any kind of consistency in the incoming data. PersonCode wasn’t always null but could be invalid.

It probably would have been better to regex the PersonCode somehow and only attempt the extraction from Notes if it was invalid. I’ll bear this in mind once the need arises again!

Cheers,

Rhys

Just wondering if:
ExtractedPersonCode AS ISnull(personcode, dbo.udf_extractPersonCode(Notes)) PERSISTED
have been cleaner?
Then you’d always have a row with the best possible personcode to use?